Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test to increase coverage rate #327

Merged
merged 1 commit into from
Jan 15, 2025
Merged

add test to increase coverage rate #327

merged 1 commit into from
Jan 15, 2025
+124 −26

Conversation

LHT129
Copy link
Collaborator

@LHT129 LHT129 commented Jan 14, 2025

  • remove *_test.cpp for coverage
  • improve hgraph

@LHT129
add test to increase coverage rate
fc1fcfc 
- remove *_test.cpp for coverage
- improve hgraph

Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
@LHT129 LHT129 added the kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) label Jan 14, 2025
@LHT129 LHT129 self-assigned this Jan 14, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

@@            Coverage Diff             @@
##             main     #327      +/-   ##
==========================================
- Coverage   88.04%   85.93%   -2.11%     
==========================================
  Files         145      109      -36     
  Lines        9316     6798    -2518     
==========================================
- Hits         8202     5842    -2360     
+ Misses       1114      956     -158
Flag Coverage Δ
cpp 85.93% <ø> (-2.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 89.48% <ø> (-2.41%) ⬇️
datacell 89.32% <ø> (-2.69%) ⬇️
index 84.03% <ø> (-2.11%) ⬇️
simd 100.00% <ø> (+24.03%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e23c784...fc1fcfc. Read the comment docs.

inabao
inabao approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@inabao inabao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wxyucs
wxyucs approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@wxyucs wxyucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LHT129 LHT129 merged commit b663e67 into antgroup:main Jan 15, 2025
12 of 16 checks passed
@LHT129 LHT129 deleted the cov branch January 15, 2025 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inabao inabao inabao approved these changes

@wxyucs wxyucs wxyucs approved these changes

@jiaweizone jiaweizone Awaiting requested review from jiaweizone jiaweizone is a code owner

Assignees

@LHT129 LHT129

Labels
kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LHT129 @wxyucs @inabao