Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

increase the code coverage of hnswlib #328

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

increase the code coverage of hnswlib #328

wants to merge 1 commit into from
+86 −250

Conversation

inabao
Copy link
Collaborator

@inabao inabao commented Jan 14, 2025 •
edited
Loading

@codecov Codecov
Copy link

codecov bot commented Jan 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

@@            Coverage Diff             @@
##             main     #328      +/-   ##
==========================================
+ Coverage   88.04%   88.51%   +0.46%     
==========================================
  Files         145      145              
  Lines        9316     9340      +24     
==========================================
+ Hits         8202     8267      +65     
+ Misses       1114     1073      -41
Flag Coverage Δ
cpp 88.51% <100.00%> (+0.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 91.89% <ø> (ø)
datacell 92.00% <ø> (ø)
index 86.94% <100.00%> (+0.79%) ⬆️
simd 75.96% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e23c784...785c681. Read the comment docs.

@inabao inabao requested a review from jiaweizone as a code owner January 14, 2025 11:49
@pull-request-size pull-request-size bot added size/L and removed size/S labels Jan 14, 2025
@inabao inabao self-assigned this Jan 14, 2025
@inabao inabao added kind/feature New feature or request version/0.13 labels Jan 14, 2025
@wxyucs wxyucs added kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) and removed kind/feature New feature or request labels Jan 14, 2025
increase the code coverage of hnswlib
785c681 
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
@inabao inabao force-pushed the increase-the-code-coverage-of-hnswlib branch from 9c25c2c to 785c681 Compare January 14, 2025 14:06
wxyucs
wxyucs approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@wxyucs wxyucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxyucs wxyucs wxyucs approved these changes

@LHT129 LHT129 Awaiting requested review from LHT129 LHT129 is a code owner

@ShawnShawnYou ShawnShawnYou Awaiting requested review from ShawnShawnYou ShawnShawnYou is a code owner

@jiaweizone jiaweizone Awaiting requested review from jiaweizone jiaweizone is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@inabao inabao

Labels
kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) size/L version/0.13
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inabao @wxyucs