Skip to content

support build ivf index with residual #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025
Merged

support build ivf index with residual #754

merged 2 commits into from
May 28, 2025

Conversation

inabao
Copy link
Collaborator

@inabao inabao commented May 25, 2025

image

@inabao inabao self-assigned this May 25, 2025
@inabao inabao added kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) version/0.15 labels May 25, 2025
Copy link

codecov bot commented May 25, 2025

Codecov Report

Attention: Patch coverage is 93.13725% with 7 lines in your changes missing coverage. Please review.

@@            Coverage Diff             @@
##             main     #754      +/-   ##
==========================================
+ Coverage   90.56%   90.58%   +0.02%     
==========================================
  Files         195      195              
  Lines       12071    12176     +105     
==========================================
+ Hits        10932    11030      +98     
- Misses       1139     1146       +7     
Flag Coverage Δ
cpp 90.58% <93.13%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 92.51% <ø> (ø)
datacell 91.68% <96.96%> (+0.05%) ⬆️
index 88.77% <92.30%> (+0.03%) ⬆️
simd 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef844a9...124dcba. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@jiaweizone jiaweizone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@LHT129 LHT129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

inabao added 2 commits May 28, 2025 11:52
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
Copy link
Collaborator

@wxyucs wxyucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@inabao inabao merged commit 5c6fe73 into main May 28, 2025
23 checks passed
@inabao inabao deleted the ivf-residual branch May 28, 2025 06:41
dasurax pushed a commit to dasurax/vsag that referenced this pull request Jun 9, 2025
Signed-off-by: jinjiabao.jjb <jinjiabao.jjb@antgroup.com>
Signed-off-by: suguan.dx <suguan.dx@antgroup.con>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) module/testing size/L version/0.15
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants