Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Waylon/time oracle #409

Merged
merged 22 commits into from
Aug 3, 2023
Merged

Waylon/time oracle #409

merged 22 commits into from
Aug 3, 2023

Conversation

0xJepsen
Copy link
Collaborator

@0xJepsen 0xJepsen commented Jul 28, 2023 •
edited
Loading

Would like some feedback on this so far. I think it's in the right direction.
Closes #352

@0xJepsen
poisson
637acbf 
update block number

fmt

passing tests 🧪

Update stochastic_new.rs

new stoacastics

new stoacastics

added
Autoparallel
Autoparallel requested changes Aug 1, 2023
View reviewed changes
Copy link
Collaborator

@Autoparallel Autoparallel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See feedback!

arbiter-core/src/environment.rs Outdated Show resolved Hide resolved
arbiter-core/src/environment.rs Outdated Show resolved Hide resolved
arbiter-core/src/environment.rs Outdated Show resolved Hide resolved
arbiter-core/src/lib.rs Outdated Show resolved Hide resolved
arbiter-core/src/manager.rs Outdated Show resolved Hide resolved
arbiter-core/src/math/mod.rs Outdated Show resolved Hide resolved
arbiter-core/src/math/stochastic_process.rs Outdated Show resolved Hide resolved
arbiter-core/src/math/stochastic_process.rs Outdated Show resolved Hide resolved
arbiter-core/src/math/stochastic_process.rs Outdated Show resolved Hide resolved
Autoparallel
Autoparallel previously requested changes Aug 2, 2023
View reviewed changes
Copy link
Collaborator

@Autoparallel Autoparallel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing crazy to change here I think. Mostly can you just look at the comments?

Last thing: Do the same tests that pass in the current feat/middleware commit still ;ass here?

I think you can just run cargo test --all --all-features

arbiter-core/src/environment.rs Show resolved Hide resolved
arbiter-core/src/environment.rs Outdated Show resolved Hide resolved
arbiter-core/src/math/stochastic_process.rs Outdated Show resolved Hide resolved
arbiter-core/src/tests.rs Outdated Show resolved Hide resolved
arbiter-core/src/agent.rs Show resolved Hide resolved
arbiter-core/Cargo.toml Outdated Show resolved Hide resolved
arbiter-core/Cargo.toml Show resolved Hide resolved
arbiter-core/src/agent.rs Show resolved Hide resolved
@0xJepsen 0xJepsen dismissed Autoparallel’s stale review August 3, 2023 18:45

adressed in latest commit

@0xJepsen 0xJepsen linked an issue Aug 3, 2023 that may be closed by this pull request
Time #352
Closed
@Autoparallel Autoparallel merged commit 274243b into feat/middleware Aug 3, 2023
0 of 4 checks passed
@0xJepsen 0xJepsen deleted the waylon/time_oracle branch August 7, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Autoparallel Autoparallel Awaiting requested review from Autoparallel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Time
2 participants
@0xJepsen @Autoparallel