-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Waylon/time oracle #409
Waylon/time oracle #409
Conversation
5dc34b3
to
0b40263
Compare
0b40263
to
637acbf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See feedback!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing crazy to change here I think. Mostly can you just look at the comments?
Last thing: Do the same tests that pass in the current feat/middleware
commit still ;ass here?
I think you can just run cargo test --all --all-features
fmt Tests seeds sample with seed
9b7f2da
to
9393047
Compare
Would like some feedback on this so far. I think it's in the right direction.
Closes #352