Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/simple #413

Merged
merged 11 commits into from
Aug 15, 2023
Merged

Feat/simple #413

merged 11 commits into from
Aug 15, 2023

Conversation

0xJepsen
Copy link
Collaborator

@0xJepsen 0xJepsen commented Aug 14, 2023

This PR pulls out a lot of things we decided not to use or are unnecessary.

  • Removes the Agent functionality
  • Removes unused dependancies
  • Renames the strategies.rs file to signers.rs which is more verbose
  • Removes un-relevant content from the root readme
  • Removes the crate readme (leftover from when is was called the simulation crate)
  • Sets the version of arbiter and crate to minor release three: v0.3.0
  • This PR also adds back the agent address determinism feature
  • This also removes some recursive error calls that were breaking functionality with stack overflows.

…vert the premature version changes

Update manager.rs
Delete agent.rs
- Stack error in recursive error calls
- Got tests passing and renamed the strategies test file to signers as it is a little more verbose
@@ -20,10 +20,6 @@ path = "bin/main.rs"

# Dependencies for the release build
[dependencies]

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused dependency

@@ -8,6 +8,9 @@
[![](https://dcbadge.vercel.app/api/server/primitive?style=flat)](https://discord.gg/primitive)
[![Twitter Badge](https://badgen.net/badge/icon/twitter?icon=twitter&label)](https://twitter.com/primitivefi)


Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sure we can improve on this in the future, but seemed like a step in the right direction. We should probably review more thoroughly before merging.

```bash
arbiter simulate uniswap
```

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all no longer relevant / incorrect with the new release so i removed it.

You will need to add the relevant directory for your new contracts to the script above and make sure they are also handled by `forge install`. We look forward to improving upon this UX in the future.

At the moment, this only builds the bindings for the contracts in the `lib/arbmod/contracts/` and `lib/portfolio/contracts`. You can of course add an additional directory of contracts in `lib/`. Just be sure to include it when you generate bindings!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also not relevant with the new release

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in this file are removing agents

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing Agents

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes here remove agents

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove Agents

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes here add the optional parameter to the RevmMiddleware Constructor that allows us to set a seed for an address.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified the deploy_and_start() to return the client of the deployer for the tests. The rest of the changes here are to get the tests to pass without agents.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed from strategies

Copy link
Collaborator

@Autoparallel Autoparallel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left small nits

arbiter-core/src/tests/interaction.rs Outdated Show resolved Hide resolved
arbiter-core/src/tests/signer.rs Outdated Show resolved Hide resolved
arbiter-core/src/tests/mod.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@Autoparallel Autoparallel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. I might add an <S: Into<String>> for creating a client.

@Autoparallel Autoparallel merged commit 395a3cb into feat/middleware Aug 15, 2023
1 of 4 checks passed
@0xJepsen 0xJepsen deleted the feat/simple branch August 16, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants