-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/simple #413
Feat/simple #413
Conversation
remove unused deps readme + version
…vert the premature version changes Update manager.rs Delete agent.rs
This reverts commit a0817e0.
- Stack error in recursive error calls - Got tests passing and renamed the strategies test file to signers as it is a little more verbose
@@ -20,10 +20,6 @@ path = "bin/main.rs" | |||
|
|||
# Dependencies for the release build | |||
[dependencies] | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused dependency
@@ -8,6 +8,9 @@ | |||
[![](https://dcbadge.vercel.app/api/server/primitive?style=flat)](https://discord.gg/primitive) | |||
[![Twitter Badge](https://badgen.net/badge/icon/twitter?icon=twitter&label)](https://twitter.com/primitivefi) | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am sure we can improve on this in the future, but seemed like a step in the right direction. We should probably review more thoroughly before merging.
```bash | ||
arbiter simulate uniswap | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is all no longer relevant / incorrect with the new release so i removed it.
You will need to add the relevant directory for your new contracts to the script above and make sure they are also handled by `forge install`. We look forward to improving upon this UX in the future. | ||
|
||
At the moment, this only builds the bindings for the contracts in the `lib/arbmod/contracts/` and `lib/portfolio/contracts`. You can of course add an additional directory of contracts in `lib/`. Just be sure to include it when you generate bindings! | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also not relevant with the new release
arbiter-core/src/environment.rs
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in this file are removing agents
arbiter-core/src/lib.rs
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing Agents
arbiter-core/src/environment.rs
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes here remove agents
arbiter-core/src/manager.rs
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove Agents
arbiter-core/src/middleware.rs
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes here add the optional parameter to the RevmMiddleware
Constructor that allows us to set a seed for an address.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modified the deploy_and_start()
to return the client of the deployer for the tests. The rest of the changes here are to get the tests to pass without agents.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed from strategies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left small nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. I might add an <S: Into<String>>
for creating a client.
This PR pulls out a lot of things we decided not to use or are unnecessary.