tests: Improves testing for all the fork logic so that the tests never fail #597
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did:
is_ok()
I also got roasted by chat gpt when i was asking it if i could grab any functionality from the binary into the lib. said that if this is the case it's an indication i should move the logic from the bin to the lib. I think this is correct long term but for now i just moved the
fork_into_arbiter
test into the bin tests since it was able to get everything we needed. Did some small cleanup around this to make it easier more modular for the future.This PR also changes CI to run on every PR now, not just ones into main.