Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind include interfaces #630

Merged
merged 4 commits into from
Oct 20, 2023
Merged

Bind include interfaces #630

merged 4 commits into from
Oct 20, 2023

Conversation

0xJepsen
Copy link
Collaborator

closes #628

This add a bool field to the toml table the we can set to want interfaces. By default it is turned off.

Copy link
Contributor

@Alexangelj Alexangelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, config nice

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #630 (2af2ddc) into main (44b6c2b) will decrease coverage by 0.08%.
Report is 4 commits behind head on main.
The diff coverage is 38.77%.

@@            Coverage Diff             @@
##             main     #630      +/-   ##
==========================================
- Coverage   60.83%   60.76%   -0.08%     
==========================================
  Files          26       26              
  Lines        5503     5533      +30     
==========================================
+ Hits         3348     3362      +14     
- Misses       2155     2171      +16     
Files Coverage Δ
bin/bind.rs 53.65% <38.77%> (-0.71%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@0xJepsen 0xJepsen merged commit 4ccb699 into main Oct 20, 2023
8 checks passed
@0xJepsen 0xJepsen deleted the bind_include_interfaces branch October 20, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bind should include interface on default and then give option to exclude them
2 participants