Fix dotfile leak by skipping non-existent deny paths #91
+4
−146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mounting /dev/null over non-existent paths creates empty files on host. Skip non-existent deny paths instead of mounting /dev/null over them. Removed: - Non-existent path protection code that created empty files - findFirstNonExistentComponent() function - Non-existent deny path protection tests Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason
Running srt generates empty dotfiles (.bashrc, .gitconfig, etc.) in working directory. Bubblewrap's
--ro-bind /dev/null /pathcreates empty files on host as mount points that persist after sandbox exits.Description
Fixes #85