Skip to content

Conversation

@JPVenson
Copy link
Contributor

No description provided.

@JPVenson JPVenson requested a review from a team as a code owner November 18, 2025 17:04
Copy link
Contributor

@packyg packyg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this!!! 🙏🏻

A couple minor tweaks

JPVenson and others added 2 commits November 18, 2025 18:13
Co-authored-by: Packy Gallagher <packy@anthropic.com>
@JPVenson JPVenson requested a review from packyg November 18, 2025 22:55
Copy link
Contributor

@packyg packyg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@sd-st
Copy link
Collaborator

sd-st commented Nov 19, 2025

I think we should probably merge this into next eh? LGTM other than that

@TomerAberbach TomerAberbach changed the base branch from main to next November 19, 2025 23:12
<RepositoryType>git</RepositoryType>
<PackageReleaseNotes>PRE-RELEASE NOT FOR DISTRIBUTION</PackageReleaseNotes>
<LangVersion>Latest</LangVersion>
<Copyright>Copyright © Stainless Software, Inc. 2024</Copyright>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct? I feel like Stainless doesn't own the copyright...? cc @packyg

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while we are at it, we should discuss the Author and Copyright ones

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a ticket to fix author/copyright in the generated code FYI, but yeah any of the custom code we'll need to sort out manually

<LangVersion>Latest</LangVersion>
<Copyright>Copyright © Stainless Software, Inc. 2024</Copyright>
<Readme>README.md</Readme>
<Description>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a description here separate of the readme? We don't have one in the other csproj iirc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they are different things. Description will be shown in the search and preview window while the readme gets shown on nuget.org.

stainless-app bot and others added 25 commits November 28, 2025 07:10
* chore: fix ci

* fix

---------

Co-authored-by: meorphis <eric@stainless.com>
Co-authored-by: Packy Gallagher <packy@anthropic.com>
Co-authored-by: Packy Gallagher <packy@anthropic.com>
@sd-st
Copy link
Collaborator

sd-st commented Dec 2, 2025

@JPVenson There seems to be a lot of extra files that shouldn't be in here I think - bad merge?

@JPVenson
Copy link
Contributor Author

JPVenson commented Dec 2, 2025

i hate rebase. Yea will close soon and make a fresh branch

@JPVenson JPVenson closed this Dec 2, 2025
@JPVenson
Copy link
Contributor Author

JPVenson commented Dec 2, 2025

Replaced by
#57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants