-
Notifications
You must be signed in to change notification settings - Fork 32
Added readme md #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added readme md #16
Conversation
packyg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding this!!! 🙏🏻
A couple minor tweaks
Co-authored-by: Packy Gallagher <packy@anthropic.com>
packyg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
|
I think we should probably merge this into |
| <RepositoryType>git</RepositoryType> | ||
| <PackageReleaseNotes>PRE-RELEASE NOT FOR DISTRIBUTION</PackageReleaseNotes> | ||
| <LangVersion>Latest</LangVersion> | ||
| <Copyright>Copyright © Stainless Software, Inc. 2024</Copyright> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this correct? I feel like Stainless doesn't own the copyright...? cc @packyg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while we are at it, we should discuss the Author and Copyright ones
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a ticket to fix author/copyright in the generated code FYI, but yeah any of the custom code we'll need to sort out manually
c78c8db to
bab3e3b
Compare
| <LangVersion>Latest</LangVersion> | ||
| <Copyright>Copyright © Stainless Software, Inc. 2024</Copyright> | ||
| <Readme>README.md</Readme> | ||
| <Description> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a description here separate of the readme? We don't have one in the other csproj iirc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they are different things. Description will be shown in the search and preview window while the readme gets shown on nuget.org.
c3e184d to
1085ba1
Compare
* chore: fix ci * fix --------- Co-authored-by: meorphis <eric@stainless.com>
* chore: fix ci * fix --------- Co-authored-by: meorphis <eric@stainless.com>
Co-authored-by: Packy Gallagher <packy@anthropic.com>
* add logo * path consistency
…n/anthropic-sdk-csharp into feature/nugetDescriptors
Co-authored-by: Packy Gallagher <packy@anthropic.com>
…n/anthropic-sdk-csharp into feature/nugetDescriptors
2732101 to
9ede62d
Compare
|
@JPVenson There seems to be a lot of extra files that shouldn't be in here I think - bad merge? |
|
i hate rebase. Yea will close soon and make a fresh branch |
|
Replaced by |
No description provided.