Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: highlight 4,000 GH stars for Shortest #17

Merged
merged 1 commit into from
Jan 9, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/2025/slides/15.tsx
Original file line number Diff line number Diff line change
@@ -21,6 +21,7 @@ export default function Slide15() {
<li>Used for Flexile</li>
<li>Used for Gumroad</li>
<li>Managed CI service</li>
<li>Reached 4,000 GitHub stars ⭐️ on Shortest!</li>
</ul>
</div>
</div>

Unchanged files with check annotations Beta

);
const totalSlides = slides.length;
const handleKeyPress = (e: KeyboardEvent) => {

Check warning on line 656 in app/2024/q4/page.tsx

GitHub Actions / Auto-fix Code Issues

The 'handleKeyPress' function makes the dependencies of useEffect Hook (at line 723) change on every render. Move it inside the useEffect callback. Alternatively, wrap the definition of 'handleKeyPress' in its own useCallback() Hook
if (e.key === "ArrowRight" && currentSlide < totalSlides) {
setCurrentSlide(currentSlide + 1);
} else if (e.key === "ArrowLeft" && currentSlide > 1) {
};
// Handle touch events for swipe navigation
const handleTouchStart = (e: TouchEvent) => {

Check warning on line 681 in app/2024/q4/page.tsx

GitHub Actions / Auto-fix Code Issues

The 'handleTouchStart' function makes the dependencies of useEffect Hook (at line 723) change on every render. Move it inside the useEffect callback. Alternatively, wrap the definition of 'handleTouchStart' in its own useCallback() Hook
setTouchStart(e.touches[0].clientX);
};
const handleTouchMove = (e: TouchEvent) => {

Check warning on line 685 in app/2024/q4/page.tsx

GitHub Actions / Auto-fix Code Issues

The 'handleTouchMove' function makes the dependencies of useEffect Hook (at line 723) change on every render. Move it inside the useEffect callback. Alternatively, wrap the definition of 'handleTouchMove' in its own useCallback() Hook
setTouchEnd(e.touches[0].clientX);
};
const handleTouchEnd = () => {

Check warning on line 689 in app/2024/q4/page.tsx

GitHub Actions / Auto-fix Code Issues

The 'handleTouchEnd' function makes the dependencies of useEffect Hook (at line 723) change on every render. Move it inside the useEffect callback. Alternatively, wrap the definition of 'handleTouchEnd' in its own useCallback() Hook
if (!touchStart || !touchEnd) return;
const distance = touchStart - touchEnd;
clearTimeout(typingTimeout);
}
};
}, [currentSlide, typedNumber, typingTimeout]);

Check warning on line 105 in components/SlideDeck.tsx

GitHub Actions / Auto-fix Code Issues

React Hook useEffect has missing dependencies: 'handleKeyPress' and 'handleTouchEnd'. Either include them or remove the dependency array
return (
<Suspense>