-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter out the hostNetwork Pods locally on Linux #7012
Conversation
e73cf12
to
d9e0df8
Compare
func(options *metav1.ListOptions) { | ||
options.FieldSelector = fields.OneTermEqualSelector("spec.hostNetwork", "false").String() | ||
}, | ||
nil, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the informer no longer needs to be filtered, you can revert back to the old version of the code since this was introduced recently
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, updated.
d9e0df8
to
aca6432
Compare
/test-all |
@wenyingd can you check the failure of the kind e2e tests? |
It looks the failed cases are not related, all cases are passed after I re-run them. |
/test-e2e |
/test-windows-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor comments about readability
This change is to resolve the issue that "spec.hostNetwork" is not supported as Pod's field selector since K8s v1.28, so we may hit issues if antrea run on a cluster with version [1.19, 1.27] . The fix is to remove the field selector "spec.hostNetwork" in the Pod list options, and locally filter out the hostNetwork Pods on Linux. This fix includes changes in both CNIServer and flow-aggregator. Signed-off-by: Wenying Dong <wenyingd@vmware.com>
aca6432
to
cef841c
Compare
/test-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Integration test is failed, I rerun it, I noticed the same failure in the release PR, not sure if there is a bug caused the flaky failure. |
I also hit the integration test failure in another CI related change (without any function code change). |
This change is to resolve the issue that "spec.hostNetwork" is not supported as Pod's field selector since K8s v1.28, so we may hit issues if antrea run on a cluster with version [1.19, 1.27] .
The fix is to remove the field selector "spec.hostNetwork" in the Pod list options, and locally filters out the hostNetwork Pod on Linux.