Fixes for Octave 5.2.0 / Bugfix in usage of dim_vector #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the documentation of dim_vector.numel() in GNU Octave 5.2.0: Return the number of elements that a matrix with this dimension vector would have, NOT the number of dimensions (elements in the dimension vector). The correct call is dim_vector.ndims(). Consequently, the template alloc_hsize(...) was removed and replaced by separate versions for Matrix and dim_vector data types. Now all tests pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I made some small fixes to compile the package on Fedora 33 with GCC 10.2.1 and GNU Octave 5.2.0 and replaced some function calls that were deprecated in GNU Octave 4.4.
Furthermore, I found an error in the usage of the Octave dim_vector class which caused a lot of tests to fail. For me, all tests now pass.
Please have a look at the changes yourself.
Best regards,
Lukas