Omit undefined
within Channels' params to fix invalid JSON serialization
#31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
undefined
within Channels' params to fix invalid JSON serializationIt's intended to mimic the ActionCable behavior when using
JSON.stringify
.Projects currently migrating from the standard ActionCable client can use optional arguments when creating Channels:
Without the change in PR, JSON is serialized incorrectly:
As a result, this leads to a failure during JSON deserialization in AnyCable Go:
null
values.It's a more controversial change as type checking will no longer catch
undefined
andnull
values, but it seems that there's no limitation on the ActionCable side.Therefore, users can rely on passing explicit
null
within params (technically, it's possible to pass Objects and Arrays in JSON as well, but I'm uncertain whether allowing these two is practical too).