Add conditional check to prevent redefining existing custom stream source element #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request introduces a safeguard in the
start.js
file to prevent the redefinition of existing custom elements. The issue was observed when legacy JQuerypage-refresh
events or jest-dom testing caused anycable to reinitiate the start function. This led to an unnecessary re-triggering of the custom stream element definition, even when the element was already present in the window.The proposed solution involves a conditional check before defining the custom element:
This approach is consistent with the convention used in the hotwired turbo library.