clang fixes allow compilation of EDLines#2
Open
translunar wants to merge 6 commits intoanyongjin:masterfrom
Open
clang fixes allow compilation of EDLines#2translunar wants to merge 6 commits intoanyongjin:masterfrom
translunar wants to merge 6 commits intoanyongjin:masterfrom
Conversation
Owner
|
libs for windows and linux has been built in |
…er is Apache (compatible). Switched setup.py licensing to "Various"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've made some small changes to the code and CMakeLists.txt to permit this to compile on a Mac.
I still cannot get it to correctly setup the Python extension, however. The problem relates to the lib directory. For example,
If I do
cp -a build/lib pylsd2/lib, it gives a different error,though it continues the install. Then, if I try to load the library in Python, I get
I'm not sure how to resolve most of these, but thought you all might be able to.