fix(metric): avoid metrics mux conflict across instances#628
Open
Ecattea wants to merge 1 commit intoanyproto:mainfrom
Open
fix(metric): avoid metrics mux conflict across instances#628Ecattea wants to merge 1 commit intoanyproto:mainfrom
Ecattea wants to merge 1 commit intoanyproto:mainfrom
Conversation
Use per-instance ServeMux in Run and add regression test for multi-instance panic.
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
The failing step check looks like a fork-permission issue, not a code/test issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use per-instance ServeMux in Run and add regression test for multi-instance panic.
Description
This PR fixes a panic when multiple metric instances are created in the same process.
Root cause:
metric.Runused globalhttp.DefaultServeMuxviahttp.Handle("/metrics", ...)andhttp.ListenAndServe(addr, nil)./metricsacross instances could panic with pattern conflict.Changes:
metric.Run:mux := http.NewServeMux()mux.Handle("/metrics", ...)http.ListenAndServe(addr, mux)TestRun_DoesNotPanicWithMultipleInstances.Validation:
go test ./metric -run TestRun_DoesNotPanicWithMultipleInstances -count=50 -vgo test ./metric -count=1 -vWhat type of PR is this? (check all applicable)
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
N/A (backend-only change)
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
None.