Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GO-4192 app start improvements #1633

Conversation

requilence
Copy link
Contributor

  • do not wait for system relations/types load/install if missing
  • try to load in background, if failed (with 30 sec timeout) then create(derive) the new one
  • if somebody will try to open this object directly - it will hang for the cache loader

Also, current bundled objects install approach work bad during reindex.

  • We have all the bundled object in spacestore, But we don't have them in objectstore
  • We check objectstore and then generate payload and try to install of them for all spaces (>1k objects if you have 10 spaces)
  • Then we receive tree already exists error for each of them
    This PR improves this by checking StoredIds along with it

@requilence requilence requested review from deff7 and mcrakhman and removed request for deff7 October 4, 2024 11:36
@requilence requilence changed the base branch from main to go-3861-prioritise-fulltext-indexing-for-spaces October 4, 2024 11:38
Copy link

github-actions bot commented Oct 4, 2024

Previous Coverage 48.4% of statements
New Coverage 48.5% of statements
Patch Coverage 52.8% of changed statements (271/513)

Coverage provided by https://github.com/seriousben/go-patch-cover-action

@requilence requilence force-pushed the go-3861-prioritise-fulltext-indexing-for-spaces branch 2 times, most recently from 49362f6 to a03b806 Compare October 4, 2024 14:42
@requilence requilence deleted the branch go-3861-prioritise-fulltext-indexing-for-spaces October 4, 2024 14:43
@requilence requilence closed this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants