Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GO-4941 Support bookmark default template #2131

Merged
merged 4 commits into from
Feb 19, 2025

Conversation

KirillSto
Copy link
Member

https://linear.app/anytype/issue/GO-4941/check-the-templates-for-bookmarks

  • split template service to interface and implementation
  • introduce templateId filed to ObjectCreateFromUrl, ObjectCreateBookmark, BlockBookmarkFetch and BlockBookmarkCreateAndFetch RPC requests

@KirillSto KirillSto changed the base branch from main to feature/primitives February 17, 2025 13:55
@KirillSto KirillSto self-assigned this Feb 17, 2025
Copy link

Testomat.io Report 🟢 SMOKE-TEST PASSED
Tests ✔️ 8 tests run
Summary 🟢 8 passed; 🟡 0 skipped
Duration 🕐 13 minutes, 5 seconds
Testomat.io Report 📊 Run #d26f5558
Job 🗂️ Smoke Tests / smoke-test
Operating System 🖥️ Linux X64

✅ Passed Tests (8)

  • Revoking an invite link (3 minutes, 4 seconds)
  • User cancels their join request (1 minute, 24 seconds)
  • User deletes the space and rejoins later (1 minute, 39 seconds)
  • Owner changes the rights of a user from Viewer to Editor (1 minute, 48 seconds)
  • Owner approves a join request with Editor permissions (1 minute, 33 seconds)
  • Owner declines a join request (1 minute, 8 seconds)
  • Owner removes a participant from the space (1 minute, 22 seconds)
  • Sync on staging nodes (1 minute, 4 seconds)

@KirillSto KirillSto marked this pull request as ready for review February 17, 2025 14:50
Copy link

New Coverage 50.7% of statements
Patch Coverage 42.5% of changed statements (135/318)

Coverage provided by https://github.com/seriousben/go-patch-cover-action

@KirillSto KirillSto merged commit 6a413fa into feature/primitives Feb 19, 2025
4 of 5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants