Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accounts: use slice instead of vec #6

Merged
merged 2 commits into from
Jun 23, 2024
Merged

accounts: use slice instead of vec #6

merged 2 commits into from
Jun 23, 2024

Conversation

cavemanloverboy
Copy link
Contributor

addresses #2

@cavemanloverboy cavemanloverboy mentioned this pull request Jun 22, 2024
Closed
buffalojoec
buffalojoec reviewed Jun 22, 2024
View reviewed changes
Copy link
Collaborator

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks! Just need that one touch-up to pass clippy (I think I broke the other one).

Since you've added the lifetime specifier to Bench, in a follow-up PR I'm going to add some more references there.

harness/src/lib.rs
Comment on lines +180 to +182
.iter()
.chain(accounts)
.cloned()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this was exactly what I had. Unfortunate, but I agree the API is better served with a reference.

@cavemanloverboy
Copy link
Contributor Author

fixed clippy

@buffalojoec buffalojoec linked an issue Jun 23, 2024 that may be closed by this pull request
accounts: Vec<_> #2
Closed
buffalojoec
buffalojoec approved these changes Jun 23, 2024
View reviewed changes
Copy link
Collaborator

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@buffalojoec buffalojoec merged commit 1f0b1a6 into anza-xyz:main Jun 23, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buffalojoec buffalojoec buffalojoec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

accounts: Vec<_>
2 participants
@cavemanloverboy @buffalojoec