Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SOL] Use SDK custom panic by default #102

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

LucasSte
Copy link
Collaborator

When static syscalls were enabled, rustc would format the panic message and log it using the sol_log_ syscall. This technique adds too many instructions to a program.

Instead, we will default to the Solana's SDK custom panic. When Rust 1.84 is available, we'll switch the existing panic to a CU and space efficient version I designed in anza-xyz/agave#4306.

@LucasSte LucasSte requested review from dmakarov and Lichtso January 24, 2025 17:43
@LucasSte LucasSte marked this pull request as ready for review January 24, 2025 17:43
@LucasSte LucasSte merged commit eda7d40 into anza-xyz:solana-1.79.0 Jan 24, 2025
14 checks passed
@LucasSte LucasSte deleted the update-panic branch January 24, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants