Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor - Subroutine for emit_validate_and_profile_instruction_count() #17

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Refactor - Subroutine for emit_validate_and_profile_instruction_count() #17

wants to merge 3 commits into from

Conversation

Lichtso
Copy link
Collaborator

@Lichtso Lichtso commented Jan 6, 2025 •
edited
Loading

Turns 30 bytes:

49 c7 c3 3b 6d f6 9e            movq   $-0x610992c5, %r11
49 81 c3 c9 92 09 61            addq   $0x610992c9, %r11
4d 39 da                        cmpq   %r11, %r10
0f 86 1e f7 ff ff               jbe    0x7ffff7e8f09d
49 81 c2 02 00 00 00            addq   $0x2, %r10

Into 15 bytes:

49 bb 8a 6c 29 fa 52 a2 86 c7   movabsq $-0x38795dad05d69376, %r11
e8 0b f9 ff ff                  callq  0x7ffff7e8f2bc

@Lichtso Lichtso force-pushed the refactor/put_emit_validate_and_profile_instruction_count_in_subroutine branch 3 times, most recently from 5e27777 to fbe00a0 Compare January 6, 2025 16:31
@Lichtso Lichtso requested a review from LucasSte January 6, 2025 16:58
LucasSte
LucasSte reviewed Jan 6, 2025
View reviewed changes
src/jit.rs Outdated
const ANCHOR_COUNT: usize = 34; // Update me when adding or removing anchors
const ANCHOR_VALIDATE_AND_PROFILE_INSTRUCTION_COUNT: usize = 21;
const ANCHOR_TRANSLATE_MEMORY_ADDRESS: usize = 22;
const ANCHOR_COUNT: usize = 35; // Update me when adding or removing anchors
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized I didn't increment the Anchor here: https://github.com/solana-labs/rbpf/pull/629/files#diff-7d39efd566d08b201d1e747f11b3909be0d39fd3d4c89cfd28e0b21bab3ec27a

Should this be 36?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, we had a gap in unused indices. I shifted them back down.

@Lichtso Lichtso force-pushed the refactor/put_emit_validate_and_profile_instruction_count_in_subroutine branch from fbe00a0 to d22086f Compare January 6, 2025 18:24
@Lichtso Lichtso requested a review from LucasSte January 6, 2025 18:34
@Lichtso Lichtso force-pushed the refactor/put_emit_validate_and_profile_instruction_count_in_subroutine branch from d22086f to f5868cb Compare January 31, 2025 14:24
@Lichtso Lichtso force-pushed the refactor/put_emit_validate_and_profile_instruction_count_in_subroutine branch from f5868cb to 9cb50a4 Compare January 31, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucasSte LucasSte LucasSte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lichtso @LucasSte