Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor - Fine tunes inline hints in JIT #32

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

Lichtso
Copy link
Collaborator

@Lichtso Lichtso commented Feb 18, 2025

Compilation throughput: +77.5%
Executable size of the compiler itself: +340 KB or +1.4%
Benchmark: 1748 programs downloaded from Solana MNB

@@ -114,7 +114,7 @@ impl X86Instruction {
immediate: 0,
};

#[inline]
#[inline(always)]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the important bit

@Lichtso Lichtso requested a review from LucasSte February 18, 2025 18:43
Copy link
Collaborator

@LucasSte LucasSte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did the size of the compiler itself increase by 340kb?

It isn't much, given the throughput improvement.

@Lichtso
Copy link
Collaborator Author

Lichtso commented Feb 21, 2025

Did the size of the compiler itself increase by 340kb?

yes

@Lichtso Lichtso merged commit 615f120 into main Feb 21, 2025
11 checks passed
@Lichtso Lichtso deleted the refactor/fine_tune_inline_hint_in_jit branch February 21, 2025 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants