Feature - Adds MMX to the x86 machinecode emitter #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
force-pushed
the
feature/x86_mmx
branch
from
cd22337 to
f9e6854
Compare
LucasSte
reviewed
Dec 30, 2024
| size, | ||
| OperandSize::S0 | OperandSize::S8 | OperandSize::S16 | OperandSize::S32 | ||
| ); | ||
| if (destination as u8) & 16 != 0 { |
There was a problem hiding this comment.
Can we write here for clarity that the bit mask tells us we have an MMX register?
Lichtso
force-pushed
the
feature/x86_mmx
branch
from
f9e6854 to
33ce85c
Compare
Lichtso
force-pushed
the
feature/x86_mmx
branch
from
33ce85c to
913e4d6
Compare
LucasSte
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.