solana-account: add AccountSharedData::data_clone method #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncinque
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
I looked for other patterns of cloning an internal Arc in a type to see if there's a standard way to name these kind of functions, but couldn't find anything in libraries like tokio / clap / std.
My one concern was that data_clone might make it sound like the underlying data is being cloned, but the return type should make that totally clear.
All in all, looks good!
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to create a lightweight view struct (anza-xyz/agave#4834) over vote account data without creating another copy of the data, I need to copy the internal
Arcwhich is private.