Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stake to internal_node_sol #59

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

CriesofCarrots
Copy link
Contributor

The stake delegated to additional (non-bootstrap) validators is funded by each of those node's respective identity key. This means that if you choose an --internal-node-stake-sol value that is larger than the default value for --internal-node-sol, the stake delegation will fail and the node will not boot. This is an annoying thing to have to remember, particularly because the --bootstrap-validator-sol and --bootstrap-validator-stake-sol args do not have this same requirement.

Update internal_node_sol to equal the value provided by the --internal-node-sol plus internal_node_stake_sol so that the id account always has enough to cover the delegation, and the remaining amount is (close to*) the configured internal node sol. (*close to, but not exact, due to transaction fees)

@CriesofCarrots
Copy link
Contributor Author

I know the behavior was inherited from the /net scripts, but it's always been annoying and imho wrong

Copy link
Collaborator

@gregcusack gregcusack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thank you!

@CriesofCarrots CriesofCarrots merged commit 8192c40 into anza-xyz:main Jul 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants