Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove constraints in bgc_phyto_raw #84

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Remove constraints in bgc_phyto_raw #84

merged 1 commit into from
Mar 13, 2024

Conversation

leonardolaiolo
Copy link
Contributor

Remove constraints as required by Claire (cell_count, sampVol_L, comments)

@leonardolaiolo leonardolaiolo linked an issue Mar 11, 2024 that may be closed by this pull request
@mhidas
Copy link
Collaborator

mhidas commented Mar 13, 2024

Thanks @leonardolaiolo - removing the constraints is simple enough, and you've done that.
Have you considered any impact on the views that get created from this raw data table? Would any rows that now have nulls in these columns be excluded from any of the _map or _data views?

@leonardolaiolo
Copy link
Contributor Author

Thanks for pointing this out Marty. In the _map we do not call any of cell_count, sampVol_L or comments. In the _data materialised views we do LEFT joints with the _map so there should be no impact.

@mhidas
Copy link
Collaborator

mhidas commented Mar 13, 2024

Great, thanks @leonardolaiolo !

@mhidas mhidas merged commit c57f03c into master Mar 13, 2024
1 check passed
@mhidas mhidas deleted the fix_bgc_phyto_raw branch March 13, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

export_bgc_phyto_raw changes
2 participants