prevent infinite loop when only 1 civ is unplayed#13
Merged
with-heart merged 1 commit intomainfrom Apr 2, 2025
Merged
Conversation
|
🚀 Preview Deployment: https://civ-randomizer-7qv8r4jyj-withhearts-projects.vercel.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prevents an infinite loop when only 1 civ is unplayed. The loop could occur if the only unplayed civ was played then unplayed, then randomize was clicked again. Since randomize prevents the next
currentCivfrom being the same as the previouscurrentCiv, it would get into a state where those values could never be different.