Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: get_bool for false case #25

Merged
merged 1 commit into from
Jul 17, 2024
Merged

bugfix: get_bool for false case #25

merged 1 commit into from
Jul 17, 2024

Conversation

Strandinator
Copy link
Contributor

currently get_bool always returns True as long as the env has a valid bool.

MY_FLAG=0 and MY_FLAG=false both result in True

@aosasona
Copy link
Owner

Blimey! That was such a silly mistake, I might have goofed that up during the rewrite, thanks for catching that!

@aosasona aosasona merged commit 92592a8 into aosasona:master Jul 17, 2024
2 checks passed
@Strandinator
Copy link
Contributor Author

All good.
Thanks for the quick response 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aosasona aosasona aosasona approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Strandinator @aosasona