Narrow table lock range for set tablet availability fate operation #5949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinrr888
reviewed
Oct 8, 2025
Comment on lines
+57
to
+58
| range.isStartKeyInclusive(), range.isInfiniteStopKey() ? null : range.getEndKey().getRow(), | ||
| range.isEndKeyInclusive()); |
Member
There was a problem hiding this comment.
Not anything for this PR but is a bit confusing that Range uses both "Stop Key" and "End Key" to mean the same thing
kevinrr888
reviewed
Oct 8, 2025
| range.isInfiniteStartKey() ? null : range.getStartKey().getRow(), | ||
| range.isStartKeyInclusive(), range.isInfiniteStopKey() ? null : range.getEndKey().getRow(), | ||
| range.isEndKeyInclusive()); | ||
| final LockRange lockRange = LockRange.of(rowRange); |
Member
There was a problem hiding this comment.
Is a RowRange object needed in this method? Seems like more info is computed than needed (inclusive start/end). Can just have
final LockRange lockRange = LockRange.of(range.isInfiniteStartKey() ? null : range.getStartKey().getRow(), range.isInfiniteStopKey() ? null : range.getEndKey().getRow())
Member
Author
|
I have converted this to draft for now. I think #5952 should be merged first as it might have some impact here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5788
The main change here is to use the version of
Utils.reserveTable()that allows us to pass a range to only lock that portion.