-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch cloudant provider from cloudant library to ibmcloudant library #41555
Conversation
53bf556
to
c3dd425
Compare
Rats, looks like the joke is on me and this PR is blocked on another third-party... There's an issue for this in the Snowflake repo (two issues actually) with an open PR, so hopefully it will be fixed soon and this Cloudant PR will unblock. Ironic as this issue stalled for a while waiting for Flask-AppBuilder to fix a dependency pin. Details:
|
9428daa
to
bb934c2
Compare
You could potentially also add "3.8" and "3.9" to "excluded-python-versions" in the new version of cloudant provider (in provider.yaml) with the link to the snowflake issue - and remove the exclusions once this problem is fixed. |
See #41548 - where we just removed such exclusion for Papermill for Python 3.12 |
I've added "all-versions" tag to the PR of yours - to make sure it's tested on all versions - so once you exclude python versions you should be able to see both CI images and tests to run for cloudant only on 3.10 -> 3.12 images and be skipped for 3.8 and 3.9 |
Great explanation, thank you @potiuk |
bb934c2
to
69efbd7
Compare
Ok @potiuk I've added the exclusion and an explanatory comment, so I think this is complete. Please review at your convenience, thanks. |
65a026d
to
2f757bf
Compare
You should also add a note at the top of changelog (see comment at the top of changelog) and bump the version to the new major release in the provider.yaml. |
d1880d5
to
63645f5
Compare
ed7950a
to
9e9e7bc
Compare
This reverts commit d36061119e05b1292cadfdc14090ec33130d1552.
ef44575
to
69ded9b
Compare
🤞 🤞 🤞 🤞 🤞 🤞 🤞 🤞🤞 🤞 🤞 🤞 🤞 🤞 🤞 🤞🤞 🤞 🤞 🤞 🤞 🤞 🤞 🤞🤞 🤞 🤞 🤞 🤞 🤞 🤞 🤞 |
Woooooohoooo! |
This has been...educational 😉 |
Oh, I am sure it was :) |
closes: #21004, cloudant is no longer developed and ibmcloudant is the active replacement
This is a breaking change to the provider in the following ways:
get_conn
now returns aCloudantV1
object with different function names than the previousCloudant
object; the mappings from the old library functions to the new are outlined here: https://github.com/cloudant/python-cloudant/blob/master/MIGRATION.md#reference-tableget_conn
now directly returns a usable object instead of a context manager;with
-block syntax is no longer neededhost
value that functions as the Cloudant account name (previously the host field was optional, but could cause a runtime failure)