-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AMORO-2938] Add common dependency chart #2939
Conversation
7f1b8e3
to
dee47cb
Compare
We cannot review the contents of the compressed package, which may be risky. Can we specify the pull this common method through http get it ? |
It's not a good idea to add a Maybe you can build the amoro helm package in an environment where the network allows it and then distribute it to the environment where it needs to be deployed |
Or Amoro can maintain built helm charts. |
ok, let me think again. |
8e3d69c
to
3d0f5cf
Compare
I copied some templates files from like doris did. |
This problem has been bothering me for a long time, nice to see that this issue is resolving. |
It's also difficult for me to download the common dependency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to put these files into a separate directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contributions
Thanks for the work! @xleoken |
Why are the changes needed?
Close #2938.
Brief change log
Due to the network issue, it's very very hard for us to pull the common dependency from
registry-1.docker.io
. We can add the dependency to the project directly.How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation