Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AMORO-2968]: Eliminate AMS Full GC impactions deriving from local terminal clean spark context #3032

Closed
wants to merge 1 commit into from
Closed

[AMORO-2968]: Eliminate AMS Full GC impactions deriving from local terminal clean spark context #3032

wants to merge 1 commit into from

Conversation

czy006
Copy link
Contributor

@czy006 czy006 commented Jul 15, 2024

Why are the changes needed?

Close #2968.

Brief change log

  • add local.spark.cleaner.referenceTracking: false in amoro terminal backend config

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible
  • Add screenshots for manual tests if appropriate
  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not documented)

@czy006 czy006 requested a review from zhoujinsong July 15, 2024 02:59
@baiyangtx
Copy link
Contributor

I think this issue is done due to #2973

@czy006
Copy link
Contributor Author

czy006 commented Jul 16, 2024

I think this issue is done due to #2973

I seem to have missed it. Thank you for your feedback

@czy006 czy006 closed this Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhoujinsong zhoujinsong Awaiting requested review from zhoujinsong

Assignees
No one assigned
Labels
type:build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improvement]: Eliminate AMS Full GC impactions deriving from local terminal clean spark context
2 participants
@czy006 @baiyangtx