-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement]: Upgrade to iceberg 1.6.0 (#3084) #3071
Conversation
ConradJam seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
a638b49
to
cd48a10
Compare
Diff ScanContext in Mixed Format , Run TestFlinkSource.testUnkeyedSnapshotRead Have Exception Do We need to set end-snapshot-id must be in streaming reader? cc @zhoujinsong |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3071 +/- ##
============================================
- Coverage 27.64% 23.17% -4.47%
+ Complexity 2496 2330 -166
============================================
Files 360 368 +8
Lines 37133 37914 +781
Branches 5372 5456 +84
============================================
- Hits 10265 8787 -1478
- Misses 25908 28353 +2445
+ Partials 960 774 -186
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
805b425
to
10bc289
Compare
ops,some time ci was blocker have long time.Maybe we should check |
It looks like there will be many engine versions that will no longer be supported. @zhoujinsong PTAL |
Maybe we should follow Iceberg 1.6, support:
What do you think? |
This will be support in the future PR, Flink 1.20 as the LTS long-term support version, I recommend as the default version option.Now Default Spark is 3.3,Flink is 1.18 |
53efd4f
to
cf801af
Compare
f0e2774
to
5a18ccd
Compare
I think it is not a good idea to remove so many versions support. Maybe we can keep the combination of old flink and old iceberg versions. @zhoujinsong @baiyangtx @czy006 And It is best to consult users on the mailing list or wechat group and make unsupported plans. |
mixed format relies on the spark and flink versions, and currently the iceberg community only supports the latest 3 versions. For example, they have to give up spark 3.2 their support.the last support in 1.4.3, iceberg if we upgrade version, we must give up its support it.flink version seems(I will add flink1.19 1.20 in the next pr),Spark now just support 3.3 |
I have initiated relevant discussions on the email list: |
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@amoro.apache.org list. Thank you for your contributions. |
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
Why are the changes needed?
#3084.
Brief change log
How was this patch tested?
Documentation