Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-2979] Support K8S Pod Template From KubernetesOptimizer (#2979) #3072

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

wangyuxiang123
Copy link
Contributor

@wangyuxiang123 wangyuxiang123 commented Jul 30, 2024

Why are the changes needed?

Close #2979.

Brief change log

  • Support K8S Pod Template From KubernetesOptimizer
  • Remove redundant comments

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible
  • Add screenshots for manual tests if appropriate
  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added the module:ams-server Ams server module label Jul 30, 2024
@czy006 czy006 self-requested a review August 1, 2024 01:57
@czy006
Copy link
Contributor

czy006 commented Aug 1, 2024

@wangyuxiang123

Thanks for your initial contribution, your code needs to make the following adjustments

  • code needs to have relevant unit tests to ensure that it does not affect existing functionality
  • use the spotless plugin to format the code and remove the comment code

Copy link
Contributor

@czy006 czy006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your first contribution, I will give you some suggestions for modifications

@wangyuxiang123 wangyuxiang123 marked this pull request as ready for review August 26, 2024 02:10
@czy006
Copy link
Contributor

czy006 commented Aug 27, 2024

Add PodTemplate Doc with Deploy AMS On Kubernetes

@github-actions github-actions bot added type:docs Improvements or additions to documentation type:build labels Aug 28, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.48%. Comparing base (f6e74aa) to head (1ad71fe).
Report is 3 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (f6e74aa) and HEAD (1ad71fe). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (f6e74aa) HEAD (1ad71fe)
core 2 0
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3072      +/-   ##
============================================
- Coverage     29.10%   22.48%   -6.62%     
+ Complexity     3647     2283    -1364     
============================================
  Files           567      379     -188     
  Lines         47025    38022    -9003     
  Branches       6193     5442     -751     
============================================
- Hits          13686     8549    -5137     
+ Misses        32359    28736    -3623     
+ Partials        980      737     -243     
Flag Coverage Δ
core ?
trino 22.48% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@czy006 czy006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I give some suggestions for modifications

Copy link
Contributor

@czy006 czy006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@czy006 czy006 merged commit 04fef53 into apache:master Sep 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:ams-server Ams server module type:build type:docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Support K8S Pod Template From KubernetesOptimizer
3 participants