-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AMORO-2979] Support K8S Pod Template From KubernetesOptimizer (#2979) #3072
Conversation
Thanks for your initial contribution, your code needs to make the following adjustments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your first contribution, I will give you some suggestions for modifications
...s-server/src/test/java/org/apache/amoro/server/manager/TestKubernetesOptimizerContainer.java
Outdated
Show resolved
Hide resolved
...s-server/src/test/java/org/apache/amoro/server/manager/TestKubernetesOptimizerContainer.java
Outdated
Show resolved
Hide resolved
1be7476
to
98759c6
Compare
...s-server/src/test/java/org/apache/amoro/server/manager/TestKubernetesOptimizerContainer.java
Outdated
Show resolved
Hide resolved
...s-server/src/test/java/org/apache/amoro/server/manager/TestKubernetesOptimizerContainer.java
Outdated
Show resolved
Hide resolved
...s-server/src/test/java/org/apache/amoro/server/manager/TestKubernetesOptimizerContainer.java
Outdated
Show resolved
Hide resolved
Add PodTemplate Doc with Deploy AMS On Kubernetes |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3072 +/- ##
============================================
- Coverage 29.10% 22.48% -6.62%
+ Complexity 3647 2283 -1364
============================================
Files 567 379 -188
Lines 47025 38022 -9003
Branches 6193 5442 -751
============================================
- Hits 13686 8549 -5137
+ Misses 32359 28736 -3623
+ Partials 980 737 -243
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
1ad71fe
to
4632dca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I give some suggestions for modifications
...o-ams-server/src/main/java/org/apache/amoro/server/manager/KubernetesOptimizerContainer.java
Outdated
Show resolved
Hide resolved
...o-ams-server/src/main/java/org/apache/amoro/server/manager/KubernetesOptimizerContainer.java
Outdated
Show resolved
Hide resolved
...o-ams-server/src/main/java/org/apache/amoro/server/manager/KubernetesOptimizerContainer.java
Outdated
Show resolved
Hide resolved
...s-server/src/test/java/org/apache/amoro/server/manager/TestKubernetesOptimizerContainer.java
Outdated
Show resolved
Hide resolved
...s-server/src/test/java/org/apache/amoro/server/manager/TestKubernetesOptimizerContainer.java
Outdated
Show resolved
Hide resolved
...s-server/src/test/java/org/apache/amoro/server/manager/TestKubernetesOptimizerContainer.java
Outdated
Show resolved
Hide resolved
648b04d
to
d0ca3f2
Compare
9388031
to
4a17a68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Why are the changes needed?
Close #2979.
Brief change log
How was this patch tested?
Documentation