Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-3163] Support for configuring the number of remaining snapshots #3164

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

XBaith
Copy link
Contributor

@XBaith XBaith commented Sep 3, 2024

Why are the changes needed?

Close #3163 .

Brief change log

  • Retain last n snapshots

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not documented)

@github-actions github-actions bot added module:ams-server Ams server module type:docs Improvements or additions to documentation labels Sep 3, 2024
@XBaith XBaith force-pushed the configure-snapshot-min-count branch from 841342f to 8ec7513 Compare September 4, 2024 02:31
Copy link
Contributor

@tcodehuber tcodehuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XBaith XBaith force-pushed the configure-snapshot-min-count branch from 8ec7513 to 71abf72 Compare September 9, 2024 07:08
@XBaith XBaith merged commit 17d9d5e into apache:master Sep 9, 2024
4 checks passed
@XBaith XBaith deleted the configure-snapshot-min-count branch September 9, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:ams-server Ams server module module:common type:docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Support for configuring the number of remaining snapshots
2 participants