[Improvement]: Refactor TableFormat to a non-enumeration type to support non-open source formats #3167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
module:mixed-spark
baiyangtx
force-pushed
the
dynamic-format
branch
from
6c9c9ca
to
72528e5
Compare
baiyangtx
force-pushed
the
dynamic-format
branch
from
cddafec
to
7db2d95
Compare
baiyangtx
force-pushed
the
dynamic-format
branch
from
34bab1d
to
482aff7
Compare
zhoujinsong
reviewed
Sep 11, 2024
There was a problem hiding this comment.
@baiyangtx Thanks for the contribution, I left some comments, PTAL.
| return TableMeta.TableType.ARCTIC.toString(); | ||
| } else if (format.equals(TableFormat.PAIMON)) { | ||
| return TableMeta.TableType.PAIMON.toString(); | ||
| } else if (format.equals(TableFormat.ICEBERG)) { |
There was a problem hiding this comment.
It seems that the processing of Iceberg and Hudi has been mixed together here.
amoro-ams/src/main/java/org/apache/amoro/server/persistence/mapper/TableMetaMapper.java
Show resolved
Hide resolved
amoro-format-iceberg/src/test/java/org/apache/amoro/catalog/TableTestBase.java
Outdated
Show resolved
Hide resolved
amoro-format-iceberg/src/main/java/org/apache/amoro/mixed/CatalogLoader.java
Outdated
Show resolved
Hide resolved
amoro-ams/src/main/java/org/apache/amoro/server/optimizing/maintainer/TableMaintainer.java
Outdated
Show resolved
Hide resolved
# Conflicts: # amoro-format-iceberg/src/main/java/org/apache/amoro/mixed/CatalogLoader.java
# Conflicts: # amoro-ams/src/main/java/org/apache/amoro/server/persistence/mapper/TableMetaMapper.java
zhoujinsong
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
We are trying to adapt a non-standard tableFormat using Amoro
Brief change log
==comparisons in your code withObject.equalsHow was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation