Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Amoro-3170] Rename format module names as amoro-format-xxx #3171

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

majin1102
Copy link
Contributor

Why are the changes needed?

Close #3170.

Brief change log

  1. Optimize format module names as amoro-format-xxxx
  2. Name sub module of amoro-format-mixed as amoro-mixed-xxxxx for better reading

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added type:docs Improvements or additions to documentation module:ams-server Ams server module module:ams-optimizer AMS optimizer module type:infra type:build labels Sep 4, 2024
@majin1102 majin1102 requested review from zhoujinsong and baiyangtx and removed request for zhoujinsong September 4, 2024 09:36
Copy link
Contributor

@baiyangtx baiyangtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@majin1102 majin1102 merged commit a52f5d4 into apache:master Sep 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:ams-optimizer AMS optimizer module module:ams-server Ams server module type:build type:docs Improvements or additions to documentation type:infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]: Optimize format module names as amoro-format-xxxx
3 participants