-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AMORO-3172] AMS ProcessStatus Miss Running Status #3173
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there some conflict between Active and RUNNING status?
Can use Running Replace Active ? cc @majin1102 |
Hi, thanks for pointing this out. This is an unreasonable reference to ProcessStatus(this belongs to process api which has not been used), the original ref is OptimizingProcess.Status. Anyway I suggest to add RUNNING and QUEUEING to take place of ACTIVE. QUEUEING means pending external process(submitted but not running) |
7eee079
to
dfada0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left one comment, PTAL
amoro-common/src/main/java/org/apache/amoro/process/TableProcessState.java
Outdated
Show resolved
Hide resolved
amoro-common/src/main/java/org/apache/amoro/process/TableProcessState.java
Outdated
Show resolved
Hide resolved
dfada0c
to
c5daa8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
a8b3183
to
417e269
Compare
Why are the changes needed?
Close #3172.
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation