Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AMORO-3195]: OptimizerController decoupling to OptimizerGroupController #3216

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[AMORO-3195]: OptimizerController decoupling to OptimizerGroupController #3216

wants to merge 1 commit into from
+473 −206

Conversation

mansonliwh
Copy link
Contributor

Why are the changes needed?

Close #3195

Brief change log

  1. The backend project has split the OptimizerController into OptimizerController and OptimizerGroupController. The OptimizerController now contains the create and release methods, while the OptimizerGroupController retains all the original logic of the OptimizerController.
  2. The frontend project has added a "Create Optimizer" button on the Optimizer page.

How was this patch tested?

image

Run test locally before making this pull request

@github-actions github-actions bot added module:ams-server Ams server module module:ams-dashboard Ams dashboard module labels Sep 23, 2024
@mansonliwh mansonliwh force-pushed the feature-optimizerdecoupling branch 2 times, most recently from 8b08f73 to d6007d9 Compare September 23, 2024 10:40
@mansonliwh mansonliwh changed the title [Amoro-3195]: OptimizerController decoupling to OptimizerGroupController [AMORO-3195]: OptimizerController decoupling to OptimizerGroupController Sep 23, 2024
@czy006
Copy link
Contributor

czy006 commented Sep 24, 2024 •
edited
Loading

image

Thank you for your contribution, do we still need to keep the Scala out button?
cc @majin1102

czy006
czy006 reviewed Sep 24, 2024
View reviewed changes
amoro-web/src/views/resource/index.vue Outdated
@@ -92,6 +98,17 @@ export default defineComponent({
state.showGroupModal = true
}

const createOptimizer = (editRecord: any | null) => {
console.log('createOptimizer function called') // 添加日志
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be remove console

amoro-web/src/views/resource/components/CreateOptimizerModal.vue Outdated
}

onMounted(() => {
console.log('Component mounted') // 添加日志
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be remove console

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the offer. It's been removed.

can be remove console

tcodehuber
tcodehuber approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@tcodehuber tcodehuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tcodehuber
Copy link
Contributor

image

Thank you for your contribution, do we still need to keep the Scala out button? cc @majin1102

I think we can remove this operation from Optimizer Groups tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czy006 czy006 czy006 left review comments

@tcodehuber tcodehuber tcodehuber approved these changes

@majin1102 majin1102 Awaiting requested review from majin1102

Assignees
No one assigned
Labels
module:ams-dashboard Ams dashboard module module:ams-server Ams server module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improvement]: OptimizerController decoupling to OptimizerGroupController
3 participants
@mansonliwh @czy006 @tcodehuber