Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AMORO-3220] Optimize table summary metrics to fetch data #3221

Merged
merged 1 commit into from
Sep 24, 2024
Merged

[AMORO-3220] Optimize table summary metrics to fetch data #3221

merged 1 commit into from
Sep 24, 2024

Conversation

MarigWeizhi
Copy link
Contributor

Why are the changes needed?

Close #3220.

Brief change log

  • fetch totalFileRecords,totalFileSize,totalFileCount from snapshot summary
  • add table_summary_dangling_delete_files metric
    danglingDeleteFiles = totalDeleteFiles - eqDeleteFiles - posDeleteFiles

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added type:docs Improvements or additions to documentation module:ams-server Ams server module labels Sep 23, 2024
zhoujinsong
zhoujinsong approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for the contribution!

@zhoujinsong zhoujinsong merged commit b157261 into apache:master Sep 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhoujinsong zhoujinsong zhoujinsong approved these changes

Assignees
No one assigned
Labels
module:ams-server Ams server module type:docs Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improvement]: Optimize table summary metrics to fetch data
2 participants
@MarigWeizhi @zhoujinsong