Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-3263] Iceberg table format displays primary key information #3264

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

zhongqishang
Copy link
Contributor

@zhongqishang zhongqishang commented Oct 16, 2024

Why are the changes needed?

Close #3263 .

Brief change log

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate
    image

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added the module:ams-server Ams server module label Oct 16, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 29.83%. Comparing base (39a5aa1) to head (d77873b).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...rver/dashboard/MixedAndIcebergTableDescriptor.java 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3264   +/-   ##
=========================================
  Coverage     29.83%   29.83%           
  Complexity     3785     3785           
=========================================
  Files           580      580           
  Lines         47932    47934    +2     
  Branches       6210     6209    -1     
=========================================
+ Hits          14299    14300    +1     
- Misses        32648    32649    +1     
  Partials        985      985           
Flag Coverage Δ
core 29.83% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for the work!

@zhoujinsong zhoujinsong merged commit 5796284 into apache:master Oct 17, 2024
4 checks passed
@zhongqishang zhongqishang deleted the AMORO-3263 branch October 22, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:ams-server Ams server module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]: Iceberg table format can not display primary key in the detail page
4 participants