[AMORO-3317]: Move optimizing planer and scan to iceberg/mixed-format module #3314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
module:ams-server
baiyangtx
force-pushed
the
remove-table-runtime-from-planner
branch
from
611c39a
to
4499ec1
Compare
baiyangtx
changed the title
baiyangtx
force-pushed
the
remove-table-runtime-from-planner
branch
from
83fe53e
to
097e958
Compare
baiyangtx
requested review from
XBaith and
zhoujinsong
and removed request for
XBaith
# Conflicts: # amoro-ams/src/main/java/org/apache/amoro/server/optimizing/OptimizingProcessMeta.java # amoro-ams/src/main/java/org/apache/amoro/server/persistence/TableRuntimeMeta.java # amoro-ams/src/test/java/org/apache/amoro/server/optimizing/BaseOptimizingChecker.java
…r' into remove-table-runtime-from-planner
zhoujinsong
reviewed
Nov 12, 2024
There was a problem hiding this comment.
@baiyangtx Thanks for the contribution!
It is very important to the new process API feature.
The PR look good to me in general, I left some minor suggestion, PTAL.
| long lastMinor = tableRuntime.getLastMinorOptimizingTime(); | ||
| long lastFull = tableRuntime.getLastFullOptimizingTime(); | ||
| TableSnapshot snapshot = IcebergTableUtil.getSnapshot(table, tableRuntime); | ||
| if (TableFormat.ICEBERG.in(table.format())) { |
There was a problem hiding this comment.
Suggested change
| if (TableFormat.ICEBERG.in(table.format())) { | |
| if (TableFormat.ICEBERG.equals(table.format())) { |
| lastMinor, | ||
| lastFull); | ||
| } | ||
| throw new IllegalStateException("Un-supported table-format:" + table.format().toString()); |
There was a problem hiding this comment.
Suggested change
| throw new IllegalStateException("Un-supported table-format:" + table.format().toString()); | |
| throw new IllegalStateException("Unsupported table format:" + table.format().toString()); |
Aireed
approved these changes
Nov 13, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
close #3317
Currently, the Optimizing Plan has become a bottleneck of AMS. A feasible solution is to delegate the Optimizing Plan to the Optimizer for execution.
For this, some prerequisite refactoring work is required.
This PR moves the code of the Optimizing Plan from the AMS module to the iceberg/mixed-format module, and the relevant logic can be called by the optimizer in the future.
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation