Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-16740: [C++] Remove IR Consumer #13301

Merged

Conversation

westonpace
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Jun 2, 2022

@github-actions
Copy link

github-actions bot commented Jun 2, 2022

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@nealrichardson
Copy link
Member

Should we also remove all of experimental/computeir?

@westonpace
Copy link
Member Author

Should we also remove all of experimental/computeir?

Good catch. Removed.

@pitrou
Copy link
Member

pitrou commented Jul 12, 2022

@westonpace It seems this PR needs updating and conflicts being fixed.

@pitrou
Copy link
Member

pitrou commented Aug 8, 2022

Ping @westonpace

@westonpace westonpace force-pushed the task/ARROW-16740--remove-compute-ir branch from 2d9823f to ae8ff20 Compare August 8, 2022 18:24
@westonpace
Copy link
Member Author

Thanks for the ping. I have rebased and will merge as CI seems to be passing.

@westonpace westonpace merged commit 5d2b8f0 into apache:master Aug 9, 2022
@ursabot
Copy link

ursabot commented Aug 9, 2022

Benchmark runs are scheduled for baseline = 78351ce and contender = 5d2b8f0. 5d2b8f0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.34% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.39% ⬆️0.04%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 5d2b8f06 ec2-t3-xlarge-us-east-2
[Finished] 5d2b8f06 test-mac-arm
[Finished] 5d2b8f06 ursa-i9-9960x
[Finished] 5d2b8f06 ursa-thinkcentre-m75q
[Finished] 78351cec ec2-t3-xlarge-us-east-2
[Finished] 78351cec test-mac-arm
[Finished] 78351cec ursa-i9-9960x
[Finished] 78351cec ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@jogomu
Copy link

jogomu commented Aug 29, 2022

arrow/cpp/build-support/update-flatbuffers.sh still has a dependency on this

@pitrou
Copy link
Member

pitrou commented Aug 29, 2022

@jogomu Yes, I noticed that in #13991 too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants