GH-46411: [C++] Implemented dataset option in Meson #47669
Merged
+226
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
force-pushed
the
meson-add-dataset
branch
7 times, most recently
from
7fde8d8 to
43c7bc1
Compare
WillAyd
force-pushed
the
meson-add-dataset
branch
from
43c7bc1 to
1ceed4e
Compare
|
@kou do you mind taking a look at this? |
kou
reviewed
Oct 11, 2025
| endif | ||
|
|
||
| needs_benchmarks = get_option('benchmarks').enabled() | ||
| needs_compute = get_option('compute').enabled() |
There was a problem hiding this comment.
Yea it was moved down later in the file because it also depends on acero
github-actions
bot
added
awaiting changes
kou
approved these changes
Oct 11, 2025
| endif | ||
|
|
||
| needs_benchmarks = get_option('benchmarks').enabled() | ||
| needs_compute = get_option('compute').enabled() |
github-actions
bot
added
awaiting review
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit c6ef0fe. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Oct 15, 2025
### Rationale for this change Adds more features to the Meson configuration ### What changes are included in this PR? Implemented the dataset option ### Are these changes tested? Yes ### Are there any user-facing changes? No * GitHub Issue: apache#46411 Authored-by: Will Ayd <william.ayd@icloud.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Adds more features to the Meson configuration
What changes are included in this PR?
Implemented the dataset option
Are these changes tested?
Yes
Are there any user-facing changes?
No