Management filtering and optimization #6226
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbertram
force-pushed
the
managementFilteringAndOptimization
branch
5 times, most recently
from
7bed1ca to
f15e5a2
Compare
Changes include: - Eliminating the use of ResourceNames values for key names when using well-known controls (e.g. address, queue, etc.). - Eliminating AMQP-specific registration methods in lieu of more general "untyped" methods since the Core broker doesn't know anything about AMQP-specific controls. - Deprecating the JMX-specific registration methods. The ManagementService itself will take care of JMX registration based on the broker's configuration. - Adding specific management methods to get names & counts for various controls instead of always creating lists. This should reduce GC pressure especially in high-load use-cases. - Leveraging filtering where appropriate for the management API. - Adding JavaDoc where method usage isn't obvious. - Eliminating Maps for server & Hawtio controls since they are singletons. - Restoring & deprecating getResource and getResources methods to ManagementService since they might be used by 3rd parties. - Eliminated all use of getResource & getResources methods throughout the code-base. - Eliminating a handful of unnecessary methods. - Eliminating unnecessary casts.
jbertram
force-pushed
the
managementFilteringAndOptimization
branch
from
f15e5a2 to
aa78c1b
Compare
Contributor
|
This one is a bit hard to review, but I haven't seen any obvious red flags so far. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took Andy's work from #6097 and split the commits more evenly so the are logically separated by task. I then added another commit that enhances the optimization work.