Skip to content

Parse values returned from Dataflow API to BoundedTrieData #34738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 10, 2025

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Apr 24, 2025

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Abacn Abacn marked this pull request as ready for review April 29, 2025 17:51
@Abacn Abacn changed the title [Do not merge] Parse struct returned from Dataflow API to BoundedTrieData Parse struct returned from Dataflow API to BoundedTrieData Apr 29, 2025
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@Abacn Abacn marked this pull request as draft April 30, 2025 19:35
fix checkstyle

Use getBoundedTrie

add debug log

adapt to ArrayMap
@Abacn Abacn force-pushed the retrive-trie branch 2 times, most recently from cefe6bb to 34e284f Compare June 6, 2025 21:24
@github-actions github-actions bot removed the java label Jun 6, 2025
@Abacn Abacn changed the title Parse struct returned from Dataflow API to BoundedTrieData Parse values returned from Dataflow API to BoundedTrieData Jun 6, 2025
@Abacn Abacn marked this pull request as ready for review June 6, 2025 22:43
Copy link
Contributor

github-actions bot commented Jun 9, 2025

Assigning reviewers:

R: @damccorm for label build.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some context on why we need this change/the Dataflow side changes enabling it? It generally seems fine, but I'm not sure why we need it

@Abacn
Copy link
Contributor Author

Abacn commented Jun 9, 2025

Could you add some context on why we need this change/the Dataflow side changes enabling it? It generally seems fine, but I'm not sure why we need it

Thanks. Internal tracker is b/404336511. Basically

As a result a "boundedTrie" field is added in Dataflow v1beta3 proto, and properly handled by this PR (tested)

"trie" will remain empty and unused. So the Dataflow side rollout won't affect Beam 2.65 and earlier versions as we had similar issue (#32622) on Beam 2.58.0

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Abacn
Copy link
Contributor Author

Abacn commented Jun 10, 2025

beam_PreCommit_Java_Amazon-Web-Services2_IO_Direct flaky workflow not related to the change

@Abacn Abacn merged commit de76cfa into apache:master Jun 10, 2025
25 of 26 checks passed
@Abacn Abacn deleted the retrive-trie branch June 10, 2025 17:45
shunping added a commit that referenced this pull request Jun 13, 2025
razvanculea pushed a commit to razvanculea/beam that referenced this pull request Jun 17, 2025
)

* Parse struct returned from Dataflow API to BoundedTrieData

fix checkstyle

Use getBoundedTrie

add debug log

adapt to ArrayMap

* Add test, clean up

* Fix test: setTrie -> setBoundedTrie

* Fix comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants