-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Parse values returned from Dataflow API to BoundedTrieData #34738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
fix checkstyle Use getBoundedTrie add debug log adapt to ArrayMap
cefe6bb
to
34e284f
Compare
Assigning reviewers: R: @damccorm for label build. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add some context on why we need this change/the Dataflow side changes enabling it? It generally seems fine, but I'm not sure why we need it
...ogle-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowMetrics.java
Outdated
Show resolved
Hide resolved
Thanks. Internal tracker is b/404336511. Basically
As a result a "boundedTrie" field is added in Dataflow v1beta3 proto, and properly handled by this PR (tested) "trie" will remain empty and unused. So the Dataflow side rollout won't affect Beam 2.65 and earlier versions as we had similar issue (#32622) on Beam 2.58.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
beam_PreCommit_Java_Amazon-Web-Services2_IO_Direct flaky workflow not related to the change |
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.