-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Adds proto fields for overwriting fetch/write state functionality #36708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Adds proto fields for overwriting fetch/write state functionality #36708
Conversation
Summary of ChangesHello @wolfchris-google, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces foundational changes to the Beam Fn API by adding new fields to the "ProcessBundleRequest" protocol buffer. The primary purpose is to provide mechanisms for controlling state management during bundle processing, allowing for future optimizations where the SDK can intelligently skip state fetch and write operations. This enhancement aims to improve the efficiency of data processing by reducing redundant state interactions. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
r: @kennknowles r: @ryan-mbuashundip this is an updated PR of my previous changes. Thought just making a new PR would be easier than cleaning the old one. |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
ryan-mbuashundip
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| // If "true", SDK will skip state fetch | ||
| bool key_has_no_state = 4; | ||
|
|
||
| // If "true", SDK will skip state write |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bundles are not restricted to have a single key. In fact they very frequently have a whole key range. Do these booleans mean that no key in the bundle has any state / has any further bundles?
In addition to resolving that issue, please document more fully and focus on semantics/specification/requirements.
For example:
only_bundle_for_key: Indicates that the runner will never process another bundle for the [keys in this bundle] so state need not be included in the bundle commit.key_has_no_state: Indicates that the runner has no state for the [keys in this bundle] so an SDK can safely begin stateful processing with a locally-generated initial empty state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bundles are not restricted to have a single key. In fact they very frequently have a whole key range.
Is this true for streaming as well?
Do these booleans mean that no key in the bundle has any state / has any further bundles?
Given that state is a function of the operation/transform I believe this is safe to assume.
Thanks for the example blurbs, I think they cover the intention of the bits well. Given your clarification, has_no_keyed_state and only_bundle_for_keys are better names for these bits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the fields and use your recommended comments for documentation. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kennknowles please re-review when you get a chance!
1403ace to
f65ec40
Compare
Adds protos to ProcessBundleRequest that will later enable skipping fetching/writing state input.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.