Skip to content

Conversation

@damccorm
Copy link
Contributor

@damccorm damccorm commented Dec 4, 2025

Fix #30760 on release branch


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @damccorm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue related to ARM dependencies by standardizing the inclusion of the google-cloud-kms library across multiple Python environments. The changes ensure that all relevant Python container images (for Python 3.10-3.13, including ML and GPU variants) have the necessary google-cloud-kms dependency, which is crucial for applications requiring key management services. A corresponding trivial change was made to a CI trigger file, likely to initiate a fresh build and test cycle to validate these dependency updates.

Highlights

  • Dependency Update: The google-cloud-kms dependency has been added at version 3.7.0 to various Python container requirement files, specifically for Python versions 3.10, 3.11, 3.12, and 3.13, across both base and ML (Machine Learning) GPU image configurations.
  • CI Trigger: A minor, trivial change was made to the beam_PostCommit_Python.json GitHub Actions trigger file, incrementing its modification number from 35 to 36. This is typically done to force a re-run of the associated CI pipeline.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@damccorm damccorm marked this pull request as ready for review December 4, 2025 21:31
@damccorm
Copy link
Contributor Author

damccorm commented Dec 4, 2025

R: @Amar3tto

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@Amar3tto Amar3tto self-requested a review December 5, 2025 15:29
@damccorm damccorm merged commit fecd5e1 into release-2.70 Dec 5, 2025
99 of 111 checks passed
@damccorm damccorm deleted the users/damccorm/arm-fix branch December 5, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants