Skip to content

[ErrorProne] Fix UnnecessaryMethodReference Check Findings #37785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stankiewicz wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −12
Open

[ErrorProne] Fix UnnecessaryMethodReference Check Findings #37785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1565,7 +1565,6 @@ class BeamModulePlugin implements Plugin<Project> {
"UndefinedEquals",
"UnescapedEntity",
"UnnecessaryLambda",
"UnnecessaryMethodReference",
"UnnecessaryParentheses",
"UnrecognisedJavadocTag",
"UnsafeReflectiveConstructionCast",
Expand Down
15 changes: 6 additions & 9 deletions sdks/java/core/src/test/java/org/apache/beam/sdk/io/TextIOWriteTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,38 +328,35 @@ public void testDynamicDefaultFilenamePolicy() throws Exception {
StreamSupport.stream(
elements.stream()
.filter(
Predicates.compose(new StartsWith("a"), new ExtractWriteDestination())
::apply)
Predicates.compose(new StartsWith("a"), new ExtractWriteDestination()))
.collect(Collectors.toList())
.spliterator(),
false)
.map(Functions.toStringFunction()::apply)
.map(Functions.toStringFunction())
.collect(Collectors.toList()),
Comment on lines 328 to 336
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This stream processing logic can be simplified. The intermediate collection to a list, getting a spliterator, and then creating a new stream via StreamSupport.stream is unnecessary and less efficient than chaining the stream operations directly. This simplification can be applied to the logic for bElements and cElements as well.

            elements.stream()
                .filter(
                    Predicates.compose(new StartsWith("a"), new ExtractWriteDestination()))
                .map(Functions.toStringFunction())
                .collect(Collectors.toList()),

String.class);
String[] bElements =
Iterables.toArray(
StreamSupport.stream(
elements.stream()
.filter(
Predicates.compose(new StartsWith("b"), new ExtractWriteDestination())
::apply)
Predicates.compose(new StartsWith("b"), new ExtractWriteDestination()))
.collect(Collectors.toList())
.spliterator(),
false)
.map(Functions.toStringFunction()::apply)
.map(Functions.toStringFunction())
.collect(Collectors.toList()),
String.class);
String[] cElements =
Iterables.toArray(
StreamSupport.stream(
elements.stream()
.filter(
Predicates.compose(new StartsWith("c"), new ExtractWriteDestination())
::apply)
Predicates.compose(new StartsWith("c"), new ExtractWriteDestination()))
.collect(Collectors.toList())
.spliterator(),
false)
.map(Functions.toStringFunction()::apply)
.map(Functions.toStringFunction())
.collect(Collectors.toList()),
String.class);
assertOutputFiles(
Expand Down
4 changes: 2 additions & 2 deletions sdks/java/harness/src/main/java/org/apache/beam/fn/harness/CombineRunners.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,11 +123,11 @@ void startBundle() {
}

void processElement(WindowedValue<KV<KeyT, InputT>> elem) throws Exception {
getGroupingTable().put(elem, output::accept);
getGroupingTable().put(elem, output);
}

void finishBundle() throws Exception {
getGroupingTable().flush(output::accept);
getGroupingTable().flush(output);
groupingTable = null;
}
}
Expand Down
Loading