Revert "fix(python): Register all output pcollections of a transform rather than only ones that happened to be accessed in DoOutputsTuple"

[claudevdm]

Reverts #37556

This breaks some internal pipelines. I am going to revert until I can figure out what exactly the problem is (it has something to do with flume runner).

[claudevdm]

R: @jrmccluskey

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a critical revert of a recent change that aimed to register all output PCollections from a transform. The original change introduced regressions, causing internal pipelines to fail, especially with the Flume runner. By reverting this commit, the PR restores stability and allows for further investigation into the root cause of the pipeline failures without blocking ongoing development.

Highlights

• Reverted PCollection registration logic: This pull request reverts a previous change that modified how output PCollections are registered within a transform, specifically undoing the registration of all outputs rather than only those explicitly accessed.
• Addressed pipeline breakage: The revert was necessary due to the previous change causing regressions and breaking internal pipelines, particularly when used with the Flume runner.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• sdks/python/apache_beam/pipeline.py
  • Reverted the iteration logic in _apply_internal from all_tags to result._pcolls.items(), effectively undoing the change that registered all output PCollections.
• sdks/python/apache_beam/pipeline_test.py
  • Modified the assertion in test_pipeline_construction from len(xform.outputs) == 3 back to len(xform.outputs) == 2, reflecting the correct number of expected outputs after the revert.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[claudevdm]

R: @tvalentyn

[claudevdm]

R: @shunping

[github-actions]

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

[github-actions]

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

[github-actions]

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers